Skip to content

Fix jvm8 lamba related issues. #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2015
Merged

Fix jvm8 lamba related issues. #483

merged 6 commits into from
Apr 16, 2015

Conversation

@DarkDimius
Copy link
Contributor

@DarkDimius DarkDimius commented Apr 16, 2015

No description provided.

@DarkDimius
Make dotty Idents transparent for common interface
2b307b4 
Scalac in some location(assigns for example) assumes that tree is a Select.
In dotty it could also be an Ident.
Simulate this.
Fixes scala#477
@DarkDimius
Refactor BackendInterface.Select: desuggar only once.
62ac97d
@DarkDimius
Give more precise types in desugarIdent.
7a347a0 
It is known to return an actual Select.
@DarkDimius
Copy link
Contributor Author

DarkDimius commented Apr 16, 2015

@smarter please review.

@DarkDimius
Copy link
Contributor Author

DarkDimius commented Apr 16, 2015

ahh. needs to be merged after #479, as it relies on behavior introduced there.

@DarkDimius
Force loading LambdaMetaFactory.
58a6c76 
Common interface with scalac tries not to load it it wasn't loaded already.
We need it.
@DarkDimius
Update version of scalac-compiler fork.
235df32 
This update allows to have non-static lambdas.
It doesn't mean that we should emit such,
as they are potential memory leak. See scala#480
Fixes scala#470
@DarkDimius
Copy link
Contributor Author

DarkDimius commented Apr 16, 2015

@odersky, please update your dependencies: https://repo1.maven.org/maven2/me/d-d/scala-compiler/2.11.5-20150416-144435-09c4a520e1/scala-compiler-2.11.5-20150416-144435-09c4a520e1.jar
This update allows to have non-static implementations of SAMs.

@smarter
Copy link
Member

smarter commented Apr 16, 2015

Lgtm

DarkDimius added a commit that referenced this pull request Apr 16, 2015
@DarkDimius
Merge pull request #483 from dotty-staging/fix-java8-alt
85b48de 
Fix jvm8 lamba related issues.
@DarkDimius DarkDimius merged commit 85b48de into scala:master Apr 16, 2015
@allanrenucci allanrenucci deleted the fix-java8-alt branch December 14, 2017 19:20
tgodzik added a commit to tgodzik/scala3 that referenced this pull request Jul 23, 2025
@tgodzik
Merge pull request scala#483 from scala/backport-lts-3.3-23462
1677c33 
Backport "Exclude named parameters inlay hints for java defined" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DarkDimius @smarter